Skip to content

Handle http(s):// prefixed endpoints properly in all cases#35

Merged
alienzach merged 2 commits intomasterfrom
endpoints-fix
Jun 23, 2020
Merged

Handle http(s):// prefixed endpoints properly in all cases#35
alienzach merged 2 commits intomasterfrom
endpoints-fix

Conversation

@njhill
Copy link
Copy Markdown
Contributor

@njhill njhill commented Jun 22, 2020

Also

  • Stop using deprecated method in grpc NameResolver API
  • Add unit tests

Fixes #34

njhill added 2 commits June 22, 2020 10:47
Also
- Stop using deprecated method in grpc NameResolver API
- Add unit tests
@njhill njhill requested a review from alienzach June 22, 2020 22:05
Copy link
Copy Markdown
Contributor

@alienzach alienzach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@alienzach alienzach merged commit 551b969 into master Jun 23, 2020
@njhill njhill deleted the endpoints-fix branch June 23, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

java.lang.IllegalArgumentException: cannot find a NameResolver

2 participants